From 7351bdf240e2305bd40f8156b9b6bf6ccaec27c2 Mon Sep 17 00:00:00 2001 From: Philipp Hahn Date: Thu, 8 Dec 2011 17:15:16 +0000 Subject: [PATCH] xend: fix insufficient quoting in tapdisk Fix insufficient quoting between "tap-ctl list" and xend/server/BlktapController.py The "line.split(None, 4)" needs to be a "3", because 3 splits needs to be done to get the 4 parts. Sorry for the mixup. [ fix to 24335:3915bd95ade5. -iwj ] Committed-by: Ian Jackson --- tools/python/xen/xend/server/BlktapController.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/python/xen/xend/server/BlktapController.py b/tools/python/xen/xend/server/BlktapController.py index 51647e2d92..60079ebe81 100644 --- a/tools/python/xen/xend/server/BlktapController.py +++ b/tools/python/xen/xend/server/BlktapController.py @@ -253,7 +253,7 @@ class TapdiskController(object): tapdisk = TapdiskController.Tapdisk() # Since 'tap-ctl list' does not escape blanks in the path, hard-code the current format using 4 pairs to prevent splitting the path - for pair in line.split(None, 4): + for pair in line.split(None, 3): key, value = pair.split('=', 1) if key == 'pid': tapdisk.pid = value -- 2.30.2